[PATCH] D13740: Catch combine opportunities for redundant imuls
Sanjay Patel via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 16 09:36:24 PDT 2015
spatel added a comment.
In http://reviews.llvm.org/D13740#268529, @zansari wrote:
> Thanks, Simon... Let me work on that, and hopefully that will also answer Sanjay's last question regarding needing a vector version in the lit test, to which I didn't comment on earlier.
Thanks for the updates, Zia. Yes, we should have a vector test since this code is designed to handle vectors. Alternatively, you could bail out on vectors in this patch, add a TODO comment for that case, and make vector handling a small follow-on patch.
And yes, I'd certainly like to make this work for 64-bit too and see if http://reviews.llvm.org/D13757 will help in that case.
http://reviews.llvm.org/D13740
More information about the llvm-commits
mailing list