[PATCH] D13193: Add an MCTargetMachine and use it to configure MCAsmInfo

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 16 07:23:06 PDT 2015


dsanders added a comment.

Great! I think it's best to abandon this patch and then I'll post a patch that just does the encapsulation step. After that, I'll post another version of this patch starting from that point. Does that sound good?

> ... is that MCTargetMachine holds an owning pointer to MCCodeGenInfo, MCAsmInfo ...


I've realised I made a mistake here. The pointers ought to be owned by the caller of MCTargetMachine::create*(). This is consistent with TargetMachine.


http://reviews.llvm.org/D13193





More information about the llvm-commits mailing list