[PATCH] D13775: Support unknown types in looksLikeFloatCastOverflowDataV1 heuristic.

[Filipe Cabecinhas via llvm-commits]

filcab added a comment.

LGTM. Creating another entry function was what we were avoiding. ;-)


================
Comment at: lib/ubsan/ubsan_handlers.cc:320
@@ -320,1 +319,3 @@
+  // adding two printable characters will not yield such a value. Otherwise,
+  // if one of them is 0xff, this is probably TK_Unknown type descriptor.
   u16 MaybeFromTypeKind =
----------------
Minor nit: s/probably/most likely/


Repository:
  rL LLVM

http://reviews.llvm.org/D13775