[llvm] r250482 - [IndVars] Extract out a few local variables; NFC

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 18:00:44 PDT 2015


Author: sanjoy
Date: Thu Oct 15 20:00:44 2015
New Revision: 250482

URL: http://llvm.org/viewvc/llvm-project?rev=250482&view=rev
Log:
[IndVars] Extract out a few local variables; NFC

Modified:
    llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp

Modified: llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp?rev=250482&r1=250481&r2=250482&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp (original)
+++ llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp Thu Oct 15 20:00:44 2015
@@ -957,25 +957,29 @@ Instruction *WidenIV::cloneIVUser(Narrow
 }
 
 Instruction *WidenIV::cloneBitwiseIVUser(NarrowIVDefUse DU) {
-  DEBUG(dbgs() << "Cloning bitwise IVUser: " << *DU.NarrowUse << "\n");
+  Instruction *NarrowUse = DU.NarrowUse;
+  Instruction *NarrowDef = DU.NarrowDef;
+  Instruction *WideDef = DU.WideDef;
+
+  DEBUG(dbgs() << "Cloning bitwise IVUser: " << *NarrowUse << "\n");
 
   // Replace NarrowDef operands with WideDef. Otherwise, we don't know anything
   // about the narrow operand yet so must insert a [sz]ext. It is probably loop
   // invariant and will be folded or hoisted. If it actually comes from a
   // widened IV, it should be removed during a future call to widenIVUse.
-  Value *LHS = (DU.NarrowUse->getOperand(0) == DU.NarrowDef)
-                   ? DU.WideDef
-                   : getExtend(DU.NarrowUse->getOperand(0), WideType, IsSigned,
-                               DU.NarrowUse);
-  Value *RHS = (DU.NarrowUse->getOperand(1) == DU.NarrowDef)
-                   ? DU.WideDef
-                   : getExtend(DU.NarrowUse->getOperand(1), WideType, IsSigned,
-                               DU.NarrowUse);
+  Value *LHS =
+      (NarrowUse->getOperand(0) == NarrowDef)
+          ? WideDef
+          : getExtend(NarrowUse->getOperand(0), WideType, IsSigned, NarrowUse);
+  Value *RHS =
+      (NarrowUse->getOperand(1) == NarrowDef)
+          ? WideDef
+          : getExtend(NarrowUse->getOperand(1), WideType, IsSigned, NarrowUse);
 
-  auto *NarrowBO = cast<BinaryOperator>(DU.NarrowUse);
+  auto *NarrowBO = cast<BinaryOperator>(NarrowUse);
   auto *WideBO = BinaryOperator::Create(NarrowBO->getOpcode(), LHS, RHS,
                                         NarrowBO->getName());
-  IRBuilder<> Builder(DU.NarrowUse);
+  IRBuilder<> Builder(NarrowUse);
   Builder.Insert(WideBO);
   if (const auto *OBO = dyn_cast<OverflowingBinaryOperator>(NarrowBO)) {
     if (OBO->hasNoUnsignedWrap())
@@ -988,25 +992,29 @@ Instruction *WidenIV::cloneBitwiseIVUser
 
 Instruction *WidenIV::cloneArithmeticIVUser(NarrowIVDefUse DU,
                                             const SCEVAddRecExpr *WideAR) {
-  DEBUG(dbgs() << "Cloning arithmetic IVUser: " << *DU.NarrowUse << "\n");
+  Instruction *NarrowUse = DU.NarrowUse;
+  Instruction *NarrowDef = DU.NarrowDef;
+  Instruction *WideDef = DU.WideDef;
+
+  DEBUG(dbgs() << "Cloning arithmetic IVUser: " << *NarrowUse << "\n");
 
   // Replace NarrowDef operands with WideDef. Otherwise, we don't know anything
   // about the narrow operand yet so must insert a [sz]ext. It is probably loop
   // invariant and will be folded or hoisted. If it actually comes from a
   // widened IV, it should be removed during a future call to widenIVUse.
-  Value *LHS = (DU.NarrowUse->getOperand(0) == DU.NarrowDef)
-                   ? DU.WideDef
-                   : getExtend(DU.NarrowUse->getOperand(0), WideType, IsSigned,
-                               DU.NarrowUse);
-  Value *RHS = (DU.NarrowUse->getOperand(1) == DU.NarrowDef)
-                   ? DU.WideDef
-                   : getExtend(DU.NarrowUse->getOperand(1), WideType, IsSigned,
-                               DU.NarrowUse);
+  Value *LHS =
+      (NarrowUse->getOperand(0) == NarrowDef)
+          ? WideDef
+          : getExtend(NarrowUse->getOperand(0), WideType, IsSigned, NarrowUse);
+  Value *RHS =
+      (NarrowUse->getOperand(1) == NarrowDef)
+          ? WideDef
+          : getExtend(NarrowUse->getOperand(1), WideType, IsSigned, NarrowUse);
 
-  auto *NarrowBO = cast<BinaryOperator>(DU.NarrowUse);
+  auto *NarrowBO = cast<BinaryOperator>(NarrowUse);
   auto *WideBO = BinaryOperator::Create(NarrowBO->getOpcode(), LHS, RHS,
                                         NarrowBO->getName());
-  IRBuilder<> Builder(DU.NarrowUse);
+  IRBuilder<> Builder(NarrowUse);
   Builder.Insert(WideBO);
   if (const auto *OBO = dyn_cast<OverflowingBinaryOperator>(NarrowBO)) {
     if (OBO->hasNoUnsignedWrap())




More information about the llvm-commits mailing list