[PATCH] D13372: [RS4GC] Use "deopt" operand bundles

[Philip Reames via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM w/minor comments.  My concern about test duplication still stands, but given this is a temporary step, I'm okay with it for a short period.


================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:79
@@ +78,3 @@
+    AllowStatepointWithNoDeoptInfo("rs4gc-allow-statepoint-with-no-deopt-info",
+                                   cl::Hidden, cl::init(false));
+
----------------
I think this needs to default to true.

================
Comment at: lib/Transforms/Scalar/RewriteStatepointsForGC.cpp:1416
@@ +1415,3 @@
+    // We don't fill in TransitionArgs or Flags in this branch, but we could
+    // have an operand bundle for that too.
+    AttributeSet OriginalAttrs = CS.getAttributes();
----------------
Add a TODO please.


http://reviews.llvm.org/D13372