[PATCH] D13455: [safestack] Fast access to the unsafe stack pointer on AArch64/Android.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 13:47:01 PDT 2015


On Thu, Oct 15, 2015 at 1:42 PM Evgeniy Stepanov <eugenis at google.com> wrote:

> eugenis added a comment.
>
> I just think that repeating a rather long string constant four times in
> the source code is typo-prone and less readable.
>
>
My only comment there is that the variable name is nearly as long ;)

-eric


>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13455
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151015/c1d8a89a/attachment.html>


More information about the llvm-commits mailing list