[lld] r250372 - [ELF2/PPC64] Remove now-dead weak/undef check

[Hal Finkel via llvm-commits]

----- Original Message -----
> From: "Rafael Espíndola" <rafael.espindola at gmail.com>
> To: "Hal Finkel" <hfinkel at anl.gov>
> Cc: "llvm-commits" <llvm-commits at lists.llvm.org>
> Sent: Thursday, October 15, 2015 7:07:37 AM
> Subject: Re: [lld] r250372 - [ELF2/PPC64] Remove now-dead weak/undef check
> 
> Thanks!

I was wrong, unfortunately, and I reverted this in r250423. I did, however, add a test case.

 -Hal

> 
> On 15 October 2015 at 02:44, Hal Finkel via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
> > Author: hfinkel
> > Date: Thu Oct 15 01:44:19 2015
> > New Revision: 250372
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=250372&view=rev
> > Log:
> > [ELF2/PPC64] Remove now-dead weak/undef check
> >
> > After r250311, this check is dead. Remove it.
> >
> > Modified:
> >     lld/trunk/ELF/Target.cpp
> >
> > Modified: lld/trunk/ELF/Target.cpp
> > URL:
> > http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Target.cpp?rev=250372&r1=250371&r2=250372&view=diff
> > ==============================================================================
> > --- lld/trunk/ELF/Target.cpp (original)
> > +++ lld/trunk/ELF/Target.cpp Thu Oct 15 01:44:19 2015
> > @@ -406,7 +406,7 @@ bool PPC64TargetInfo::relocNeedsPlt(uint
> >      return false;
> >
> >    // These are function calls that need to be redirected through a
> >    PLT stub.
> > -  return S.isShared() || (S.isUndefined() && S.isWeak());
> > +  return S.isShared();
> >  }
> >
> >  bool PPC64TargetInfo::isRelRelative(uint32_t Type) const {
> >
> >
> > _______________________________________________
> > llvm-commits mailing list
> > llvm-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory