[PATCH] D13760: ELF2: Implement __start_SECNAME and __stop_SECNAME.

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 08:39:31 PDT 2015


davide added a comment.

I'm not familiar enough with this part of the standard but I always thought C identifiers were only:

- upper/lower case a-z
- digits 0-9
- underscore (_)

I checked doc and it seems to confirm: https://msdn.microsoft.com/en-us/library/e7f8y25b.aspx
I also noticed that this is exactly what gold does. If accepting '$' is an extension or clang is wrong here, I don't know, but I don't think we should accept '$' as valid C identifier in this case.


http://reviews.llvm.org/D13760





More information about the llvm-commits mailing list