[PATCH] D13753: Use Windows Vista API to get the user's home directory

Greg Bedwell via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 15 06:27:30 PDT 2015


gbedwell added a comment.

In http://reviews.llvm.org/D13753#267904, @chfast wrote:

> I've checked that. `-T "v120_xp"` option do not modify CMAKE_SYSTEM variables. The toolset option itself can by queried with CMAKE_GENERATOR_TOOLSET variable but only if was explicitly set. Considering all possible combination of options (MSVC, toolset, mingw32, mingw-w64) I would avoid detecting unsupported targeted Windows version in cmake script.


Great.  Thanks for checking!  I absolutely agree with your reasoning, so please do not worry about the CMake check suggestion.


Repository:
  rL LLVM

http://reviews.llvm.org/D13753





More information about the llvm-commits mailing list