[PATCH] D13753: Use Windows Vista API to get the user's home directory

[Greg Bedwell via llvm-commits]

gbedwell added a comment.

In http://reviews.llvm.org/D13753#267864, @chfast wrote:

> CMake warning should be about "you're building LLVM on a version of Windows that not meet minimum requirements"?
>  I think the main problem is *running* binaries (built on supported Windows) on not-supported versions of Windows, isn't it?


This should be the distinction between CMAKE_HOST_SYSTEM_VERSION (OS version CMake is running on) and CMAKE_SYSTEM_VERSION (The OS version CMake is building for) (according to https://cmake.org/cmake/help/v2.8.12/cmake.html#section_VariablesThatDescribetheSystem ).  My fear that it was still possible to build with the CMake option "-T vs120_xp" to specify an XP targeting platform toolset, but having just tried it to see whether it affects CMAKE_SYSTEM_VERSION or not, I've not actually been able to get that far without running into weird CMake errors so I'm not convinced that anyone would be able to use it anyway.  As I said, I don't feel too strongly about this.  It's been documented for a while that XP will no longer be supported and nobody leapt into the discussion to state that they still cared, so I don't think it's important to present a user friendly CMake-time error.  It would just be nice if it turned out to be trivial.


Repository:
  rL LLVM

http://reviews.llvm.org/D13753