[PATCH] D13749: x86 atomic codegen: don't drop globals

[Pete Cooper via llvm-commits]

pete added a comment.

In http://reviews.llvm.org/D13749#267456, @jfb wrote:

> The bug was introduced in http://reviews.llvm.org/D11382.
>
> I'm not a huge fan of the code duplication, but it seems easier to read that cleverly reusing partially-constructed MIs.
>
> Also, the code currently checks for global and immediate since they seem to be the only possible displacements. Should I test immediate? That's just a bitcast of a value, right?


Yeah, exactly, just a bit cast of an immediate.

> Any other corner case?


Can't think of anything.  I assume that a floating point literal, with a bit cast, would just constant fold to an integer anyway.


http://reviews.llvm.org/D13749