[PATCH] D13749: x86 atomic codegen: don't drop globals

[JF Bastien via llvm-commits]

jfb added a comment.

The bug was introduced in http://reviews.llvm.org/D11382.

I'm not a huge fan of the code duplication, but it seems easier to read that cleverly reusing partially-constructed MIs.

Also, the code currently checks for global and immediate since they seem to be the only possible displacements. Should I test immediate? That's just a bitcast of a value, right?

Any other corner case?


http://reviews.llvm.org/D13749