[PATCH] D13253: Tighten known bits for ctpop based on zero input bits

Sanjoy Das via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 15:20:26 PDT 2015


sanjoy accepted this revision.
sanjoy added a reviewer: sanjoy.
sanjoy added a comment.
This revision is now accepted and ready to land.

LGTM.


================
Comment at: lib/Analysis/ValueTracking.cpp:1379
@@ +1378,3 @@
+                         Depth + 1, Q);
+        // we can bound the space the count needs.  Also, bits known to be zero
+        // can't contribute to the population.
----------------
Nit: capitalize `We`.

Actually, I'd just change this to say `// Bits known to be zero ...`.


http://reviews.llvm.org/D13253





More information about the llvm-commits mailing list