[PATCH] D13188: [MachO] Stop generating *coal* sections.

Jim Grosbach via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 14 13:05:04 PDT 2015


grosbach added inline comments.

================
Comment at: lib/MC/MCParser/DarwinAsmParser.cpp:599
@@ -582,1 +598,3 @@
+  }
+
   // FIXME: Arch specific.
----------------
Warning phrasing should match the usual clang/assembler pattern.  No initial capital letter, single sentence, with an additional note for the correction.

Something like:
`foo.s:1:1: warning: section "__textcoal_nt" is deprecated`
`.section __TEXT,__textcoal_nt`
`                ^~~~~~~~~~~~~`
`foo.s:1:1:        change section name to "__text"`
`.section __TEXT,__textcoal_nt`
`                ^~~~~~~~~~~~~`

This usage is analogous to the warning given if the return type of main() in a C program is not "int."


http://reviews.llvm.org/D13188





More information about the llvm-commits mailing list