[PATCH] D13426: Move types in the LLVM C API from Core to Support

[Eric Christopher via llvm-commits]

echristo added a reviewer: bogner.
echristo added a comment.

In http://reviews.llvm.org/D13426#266903, @jyknight wrote:

> This seems sane to me. Of course, user code which said only:
>
>   #include "llvm-c/BitReader.h"
>
> and then depended upon getting the functions in llvm-c/Core.h transitively included will need to add a #include "llvm-c/Core.h", but that seems perfectly fine to me. My go-to examples of extremely stable libraries, glibc and libstdc++, make that kind of change all the time, for example.
>
> Eric, do you object?


Doesn't this break the source level compatibility that was a part of what people were talking about in the C API thread?

Personally? No, I don't object and am in favor, but I don't feel comfortable approving it until we get some of the other stuff resolved.

-eric


http://reviews.llvm.org/D13426