[PATCH] D13723: [ELF2][mips] Support both big and little endian MIPS 32-bit targets
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Wed Oct 14 06:39:54 PDT 2015
atanasyan marked 2 inline comments as done.
atanasyan added a comment.
Thanks for your review.
================
Comment at: ELF/Target.cpp:585-586
@@ +584,4 @@
+ const void *RelP, uint32_t Type,
+ uint64_t BaseAddr,
+ uint64_t SymVA) const {
+ const bool IsLE = ELFT::TargetEndianness == support::little;
----------------
ruiu wrote:
> Unrelated style change.
Due the `<ELFT>` it is now impossible to keep both `BaseAddr` and `SymVA` arguments on the same line without 80-column restriction violation.
Repository:
rL LLVM
http://reviews.llvm.org/D13723
More information about the llvm-commits
mailing list