[PATCH] D13709: LegalizeDAG: Implement promote for build_vector

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 13 16:05:53 PDT 2015


arsenm added a comment.

In http://reviews.llvm.org/D13709#266477, @qcolombet wrote:

> Hi Matt,
>
> That does not seem generally profitable and make the representation more complicate in my opinion.
>  That being said, I do not see tests changes here. Does this mean the change is neutral for the in tree targets or that the tests are not covering this code?
>
> Thanks,
> -Quentin


This isn't an optimization, and no in tree target is attempting to use Promote for build_vector currently. AMDGPU already has tests that cover this which will use this in a future commit when I add v2i64 and v2f64 as legal types.


http://reviews.llvm.org/D13709





More information about the llvm-commits mailing list