[PATCH] D13670: [sanitizer] Fix ptrace interceptor for aarch64

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: test/asan/TestCases/Linux/ptrace.cc:6
@@ -5,3 +5,3 @@
 // RUN: %clangxx_asan -DPOSITIVE -O0 %s -o %t && not %run %t 2>&1 | FileCheck %s
-// REQUIRES: x86_64-supported-target,i386-supported-target
+// REQUIRES: x86_64-supported-target,i386-supported-target,aarch64-supported-target
 
----------------
zatrazz wrote:
> eugenis wrote:
> > This is impossible. You can not build compiler-rt to support all 3 of those at one time.
> > UNSUPPORTED: AddressSanitizer-x86_64-linux :: TestCases/Linux/ptrace.cc
> > UNSUPPORTED: AddressSanitizer-i386-linux :: TestCases/Linux/ptrace.cc
> > 
> > Not sure what's the best solution here. Maybe #ifdef-out the entire test on unsupported platforms?
> Right, I misunderstood the idea of REQUIRES. If there is no way to conditionally select the requirement (x86_64 or i386 or aarch64) the way I see to enable this test is to remove the 'requires', enable on all the architectures and then XFAIL on the ones that do not have the instrumented ptrace (since the CHECK: will be still being evaluated even if we #ifdef-out the tests). Suggestions?
How about listing targets this test does not run on as UNSUPPORTED: ?



http://reviews.llvm.org/D13670