[PATCH] D13651: [ELF2] - Initial lazy loading support (x86_x64 and x86)

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/OutputSections.cpp:183
@@ -139,1 +182,3 @@
+      else
+        P->r_offset = Out<ELFT>::Got->getEntryAddr(*Body);
       if (CanBePreempted)
----------------
Please add this as a comment to this function.

================
Comment at: ELF/Target.cpp:66
@@ +65,3 @@
+      0xff, 0x25, 0x00, 0x00, 0x00, 0x00, // jmpq *got(%rip)
+      0x68, 0x00, 0x00, 0x00, 0x00,       // pushq reloc-index
+      0xe9, 0x00, 0x00, 0x00, 0x00        // jmpq plt[0]
----------------
It can read relocation minus index. Maybe I'd write <relocation index> instead of reloc-index.

================
Comment at: ELF/Target.cpp:152
@@ +151,3 @@
+      0xff, 0x25, 0x00, 0x00, 0x00, 0x00, // jmpq *got(%rip)
+      0x68, 0x00, 0x00, 0x00, 0x00,       // pushq reloc-index
+      0xe9, 0x00, 0x00, 0x00, 0x00        // jmpq plt[0]
----------------
Ditto


http://reviews.llvm.org/D13651