[PATCH] D13674: [llvm-pdbdump] Provide a mechanism to dump the raw contents of a PDB

[Zachary Turner via llvm-commits]

zturner added inline comments.

================
Comment at: tools/llvm-pdbdump/llvm-pdbdump.cpp:87-92
@@ +86,8 @@
+                              cl::cat(OtherOptions));
+cl::opt<bool> DumpFileSizes("dump-file-sizes", cl::desc("dump PDB file sizes"),
+                          cl::cat(OtherOptions));
+cl::opt<bool> DumpFileBlocks("dump-file-blocks", cl::desc("dump PDB file blocks"),
+                         cl::cat(OtherOptions));
+cl::opt<std::string> DumpFileData("dump-file", cl::desc("dump file data"),
+                                  cl::cat(OtherOptions));
+
----------------
Can we refer to these as streams instead of files?  The fact that it's implemented as a file-system like thing is kind of an implementation detail, and I think it's a little confusing for people to see something like `dump-file-sizes` and get something back that is different than the size of the actual PDB file.


http://reviews.llvm.org/D13674