[PATCH] D13566: [ELF2] PPC64 needs to delay local-call relocations until after the function-descriptor values are known

[hfinkel@anl.gov via llvm-commits]

hfinkel added inline comments.

================
Comment at: ELF/OutputSections.h:290-291
@@ -289,2 +289,4 @@
   static OutputSection<ELFT> *Bss;
+  static OutputSection<ELFT> *Opd;
+  static uint8_t *OpdBuf;
   static PltSection<ELFT> *Plt;
----------------
hfinkel wrote:
> ruiu wrote:
> > Alright, I found that not look very good. How about adding these two fields to PPC64TargetInfo?
> I'll try that.
> 
> FYI: PPC64, Itanium and HPPA seem to use the .opd section. Thus, while theoretically generic, I suspect we can consider this to be PPC64-specific in practice.
> 
Alright, this can certainly be done. The largest issue is that the type of the output section depends on the target's object type, and we cannot universally stash the pointer to the section away in PPC64 target info without some form of type erasure and/or dispatch to the target.

I'll upload a pure rebase of this patch, and then a version where I've moved the data members into PPC64TargetInfo (but using a void* to get around the aforementioned issue).
 


http://reviews.llvm.org/D13566