[PATCH] D13668: [ELF2/LinkerScript] Fix OUTPUT_FORMAT directive parsing

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 14:01:30 PDT 2015


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.


================
Comment at: ELF/LinkerScript.cpp:214-215
@@ -213,1 +213,4 @@
   expect("(");
+  StringRef Tok = next();
+  Tok = next();
+  if (Tok == ")")
----------------
Please discard the result first next() and assign only the second one.


http://reviews.llvm.org/D13668





More information about the llvm-commits mailing list