[PATCH] D13668: [ELF2/LinkerScript] Fix OUTPUT_FORMAT directive parsing

[Davide Italiano via llvm-commits]

davide added a comment.

In http://reviews.llvm.org/D13668#265235, @ruiu wrote:

> s/OUTPUT_ARCH/OUTPUT_FORMAT/
>
> Rename linkerscript-outputgroup.s -> linkerscript-outputformat.s.
>
> Regarding better error handling, I don't think now is the right time to do something about that. This parser is a designed to be just enough to read Linux's libc.so, and this should suffice until we link something like a OS kernel, so designing a linker script that is capable more than this one is in my opinion relatively low priority.


This is exactly my point. In fact, I said "in the future", and not "now". That said, I think it's good to emit meaningful diagnostics for users at some point.


http://reviews.llvm.org/D13668