[PATCH] D13243: [GlobalsAA] Don't assume anything about functions that may be overridden

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 11:13:29 PDT 2015


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

This is clearly correct. Please feel free to commit.

I want to record that we can probably do much better than this. Specifically, we should model external (or replaceable) functions as mod/ref-ing all external (or captured externally) globals, but not mod/ref-ing any non-externally-captured internal globals. Not sure where the best place is to record that? If you find a good place, add the comment and move on. =]


Repository:
  rL LLVM

http://reviews.llvm.org/D13243





More information about the llvm-commits mailing list