[PATCH] D13653: [mips][mips16] Re-work the inline assembly stubs to work with IAS. NFC.

Daniel Sanders via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 12 07:47:03 PDT 2015


dsanders created this revision.
dsanders added a reviewer: vkalintiris.
dsanders added subscribers: llvm-commits, rkotler.
Herald added a subscriber: dsanders.

Previously, we were inserting an InlineAsm statement for each line of the
inline assembly. This works for GAS but it triggers prologue/epilogue
emission when IAS is in use. This caused:
    .set noreorder
    .cpload $25
to be emitted as:
    .set push
    .set reorder
    .set noreorder
    .set pop
    .set push
    .set reorder
    .cpload $25
    .set pop
which led to assembler errors and caused the test to fail.

The whitespace-after-comma changes included in this patch are necessary to
match the output when IAS is in use.

http://reviews.llvm.org/D13653

Files:
  lib/Target/Mips/Mips16HardFloat.cpp
  test/CodeGen/Mips/hf16call32.ll
  test/CodeGen/Mips/hf16call32_body.ll
  test/CodeGen/Mips/hf1_body.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D13653.37110.patch
Type: text/x-patch
Size: 22640 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151012/9275aa89/attachment.bin>


More information about the llvm-commits mailing list