[PATCH] Marked Swift Machine Scheduler Model as incomplete

[James Molloy via llvm-commits]

Hi Christof,

I committed this on your behalf in r250033. Now might be a good time to ask
for SVN commit access.

Cheers,

James

On Mon, 12 Oct 2015 at 13:02 Christof Douma via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> I've opened https://llvm.org/bugs/show_bug.cgi?id=25145 for adding the
> missing instructions.
> Can I ask somebody to commit this, as I don't have commit rights yet.
>
> Thanks,
> Christof
>
> > -----Original Message-----
> > From: Andrew Trick [mailto:atrick at apple.com]
> > Sent: 09 October 2015 19:23
> > To: Christof Douma
> > Cc: llvm-commits at lists.llvm.org; Arnold Schwaighofer; Matthias Braun
> > Subject: Re: [PATCH] Marked Swift Machine Scheduler Model as incomplete
> >
> > Hi Christof,
> >
> > The change is fine with me as long as you file a bug to get those
> instructions
> > added to the model.
> >
> > Andy
> >
> > > On Oct 9, 2015, at 8:53 AM, Christof Douma <Christof.Douma at arm.com>
> > wrote:
> > >
> > > Hi.
> > >
> > > I've got a 1-line change to the SwiftModel to mark the model as
> > incomplete.
> > > Can I get a review on this?
> > >
> > > Thanks,
> > > Christof
> > > ------------
> > > Marked Swift Machine Scheduler Model as incomplete
> > >
> > > Swift Machine Scheduler Model is incomplete. There are instructions
> > > missing which can trigger the "incomplete machine model" abort. This
> > > was observed when a downstream SchedMachineModel was added to the
> > ARM
> > > target.
> > >
> > > Change-Id: Ie43cbc8d529b6a1257a5d7b1e69e6f40d504b842
> > > ---
> > > lib/Target/ARM/ARMScheduleSwift.td | 1 +
> > > 1 file changed, 1 insertion(+)
> > >
> > > diff --git a/lib/Target/ARM/ARMScheduleSwift.td
> > > b/lib/Target/ARM/ARMScheduleSwift.td
> > > index 6f5740f..64b477d 100644
> > > --- a/lib/Target/ARM/ARMScheduleSwift.td
> > > +++ b/lib/Target/ARM/ARMScheduleSwift.td
> > > @@ -43,6 +43,7 @@ def SwiftModel : SchedMachineModel {
> > >   let MicroOpBufferSize = 45; // Based on NEON renamed registers.
> > >   let LoadLatency = 3;
> > >   let MispredictPenalty = 14; // A branch direction mispredict.
> > > +  let CompleteModel = 0;    // FIXME: Remove if all instructions are
> > > covered.
> > > }
> > >
> > > // Swift predicates.
> > > --
> > > 1.8.3
> > >
> > >
>
>
> -- IMPORTANT NOTICE: The contents of this email and any attachments are
> confidential and may also be privileged. If you are not the intended
> recipient, please notify the sender immediately and do not disclose the
> contents to any other person, use it for any purpose, or store or copy the
> information in any medium.  Thank you.
>
> ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> Registered in England & Wales, Company No:  2557590
> ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ,
> Registered in England & Wales, Company No:  2548782
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151012/4e1aa55e/attachment.html>