[PATCH] D13562: [ELF2] Add a base set of PPC64 relocations

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM with nits. Thank you for your work for PPC64!


================
Comment at: ELF/Target.cpp:218
@@ +217,3 @@
+
+static uint16_t applyPPCHighest(uint64_t V) { return (V >> 48) & 0xffff; }
+
----------------
You can remove &0xffff because least significant 48 bits are already 0.

================
Comment at: ELF/Target.cpp:221
@@ +220,3 @@
+static uint16_t applyPPCHighesta(uint64_t V) {
+  return ((V + 0x8000) >> 48) & 0xffff;
+}
----------------
Ditto


http://reviews.llvm.org/D13562