[PATCH] D13364: [x86] PR24562: fix incorrect folding of X86ISD::PSHUFB nodes that have a mask of all indices with the most significant bit set.

[Simon Pilgrim via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM - 1 final minor comment.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:21969
@@ -21957,1 +21968,3 @@
+      DCI.CombineTo(Root.getNode(), DAG.getBitcast(RootVT, Input),
+                    /*AddTo*/ true);
     return true;
----------------
The comments inside the if / else blocks can probably be removed - they can be described in the preamble above (the SentinelZero case already is) and then the fact that the blocks don't have braces isn't so jarring.


http://reviews.llvm.org/D13364