[PATCH] D13544: ELF2: Make SymbolTable a template class.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 9 13:39:39 PDT 2015


ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:165
@@ +164,3 @@
+  default:
+    llvm_unreachable("Invalid kind");
+  }
----------------
rafael wrote:
> We can get here with
> 
> ld.lld2 -u foo has_a_foo.a
> 
> no? This is not a regression, but please make it an explicit error. Something like "-m or at least a .o file required".
Done.


http://reviews.llvm.org/D13544





More information about the llvm-commits mailing list