[PATCH] D13544: ELF2: Make SymbolTable a template class.

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Driver.cpp:241
@@ +240,3 @@
+
+  for (std::unique_ptr<InputFile> &File : Files) {
+    auto *F = dyn_cast<ELFFileBase>(File.get());
----------------
rafael wrote:
> Why do you need these extra loops? You can keep checking for incompatible files as they are created, no?
I wanted to separate this error checking code from addFile for the sake of simplicity. There we create files and here we check for consistency. In this way we also don't have to propagate -m's argument just to include that into an error message.


http://reviews.llvm.org/D13544