[PATCH] D13598: Add comdat support.

[Rui Ueyama via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

This looks much better! A few minor comments.


================
Comment at: ELF/OutputSections.cpp:551
@@ -541,1 +550,3 @@
 
+  uint32_t SecIndex = Sym.st_shndx;
+  if (SecIndex != SHN_ABS) {
----------------
Add a comment saying that returning false if Sym is pointing to a discarded section group member.

================
Comment at: ELF/SymbolTable.h:98
@@ -97,1 +97,3 @@
 
+  llvm::DenseSet<StringRef> Comdats;
+
----------------
You are not using ComdatSet type here. Maybe we should just remove ComdatSet typedef and always write as DenseSet<StringRef>?


Repository:
  rL LLVM

http://reviews.llvm.org/D13598