[LNT] r249678 - Fix unit test failure introduced at r249106.

Chris Matthews via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 16:17:03 PDT 2015


I committed a fix to geomean as well, the None should have never been there!

> On Oct 8, 2015, at 4:04 PM, Chris Matthews via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> I saw this. I wondered if fixing the source would be better.  I think I have a fix, let me see if I can find it!
> 
> 
>> On Oct 8, 2015, at 3:49 AM, Kristof Beyls via llvm-commits <llvm-commits at lists.llvm.org> wrote:
>> 
>> Author: kbeyls
>> Date: Thu Oct  8 05:49:33 2015
>> New Revision: 249678
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=249678&view=rev
>> Log:
>> Fix unit test failure introduced at r249106.
>> 
>> By normalizing prev_samples to not contain None values.
>> 
>> Modified:
>>   lnt/trunk/lnt/server/reporting/analysis.py
>> 
>> Modified: lnt/trunk/lnt/server/reporting/analysis.py
>> URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/reporting/analysis.py?rev=249678&r1=249677&r2=249678&view=diff
>> ==============================================================================
>> --- lnt/trunk/lnt/server/reporting/analysis.py (original)
>> +++ lnt/trunk/lnt/server/reporting/analysis.py Thu Oct  8 05:49:33 2015
>> @@ -68,6 +68,8 @@ class ComparisonResult:
>>        # Compute the comparison status for the test value.
>>        self.delta = 0
>>        self.pct_delta = 0.0
>> +        if prev_samples:
>> +            prev_samples = [s for s in prev_samples if s is not None]
>>        if self.current and prev_samples:
>>            self.delta, value = absmin_diff(self.current, prev_samples)
>>            if value != 0:
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list