[PATCH] D13571: Add Triple::isAndroid().

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 14:03:17 PDT 2015


OK. LGTM then.

Thanks!

On Thu, Oct 8, 2015 at 2:01 PM Evgeniy Stepanov <eugenis at google.com> wrote:

> eugenis added a comment.
>
> I'd prefer isAndroid because the fact that "-android" is environment is
> more of an implementation detail, and Android is more of OS (but calling
> the function isOSAndroid would be wrong of course).
> There are precedents: isMacOSX, isiOS, isPS4.
>
>
> Repository:
>   rL LLVM
>
> http://reviews.llvm.org/D13571
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20151008/24191bda/attachment.html>


More information about the llvm-commits mailing list