[lld] r249744 - Don't silently ignore an error.

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Thu Oct  8 15:43:19 2015
New Revision: 249744

URL: http://llvm.org/viewvc/llvm-project?rev=249744&view=rev
Log:
Don't silently ignore an error.

Found by inspection.

Modified:
    lld/trunk/ELF/Writer.cpp

Modified: lld/trunk/ELF/Writer.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=249744&r1=249743&r2=249744&view=diff
==============================================================================
--- lld/trunk/ELF/Writer.cpp (original)
+++ lld/trunk/ELF/Writer.cpp Thu Oct  8 15:43:19 2015
@@ -322,9 +322,11 @@ template <class ELFT> void Writer<ELFT>:
     if (!Config->DiscardAll) {
       Elf_Sym_Range Syms = File.getLocalSymbols();
       for (const Elf_Sym &Sym : Syms) {
-        ErrorOr<StringRef> SymName = Sym.getName(File.getStringTable());
-        if (SymName && shouldKeepInSymtab<ELFT>(*SymName, Sym))
-          Out<ELFT>::SymTab->addSymbol(*SymName, true);
+        ErrorOr<StringRef> SymNameOrErr = Sym.getName(File.getStringTable());
+        error(SymNameOrErr);
+        StringRef SymName = *SymNameOrErr;
+        if (shouldKeepInSymtab<ELFT>(SymName, Sym))
+          Out<ELFT>::SymTab->addSymbol(SymName, true);
       }
     }
     for (InputSection<ELFT> *C : File.getSections()) {