[PATCH] D13542: [ELF2/LinkerScript] Support for SEARCH_DIR() directive

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 8 10:56:03 PDT 2015


On Thu, Oct 8, 2015 at 9:44 AM, Davide Italiano <davide at freebsd.org> wrote:
> On Thu, Oct 8, 2015 at 2:44 AM, Joerg Sonnenberger via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> On Thu, Oct 08, 2015 at 01:03:14AM +0000, Davide Italiano via llvm-commits wrote:
>>> Index: test/elf2/linkerscript.s
>>> ===================================================================
>>> --- test/elf2/linkerscript.s
>>> +++ test/elf2/linkerscript.s
>>> @@ -23,6 +23,10 @@
>>>  # RUN: ld.lld2 %t.script %t
>>>  # RUN: llvm-readobj %t.out > /dev/null
>>>
>>> +# RUN: echo "SEARCH_DIR(\"/lib/foo/blah\")" > %t.script
>>> +# RUN: ld.lld2 %t.script %t
>>> +# RUN: llvm-readobj %t.out > /dev/null
>>> +
>>>  # RUN: echo "FOO(BAR)" > %t.script
>>>  # RUN: not ld.lld2 -o foo %t.script > %t.log 2>&1
>>>  # RUN: FileCheck -check-prefix=ERR1 %s < %t.log
>>
>> Can you also make sure that = aka sysroot prefix is handled correctly
>> here?
>>
>> Joerg
>
> I don't think we do support --sysroot, yet, but once we will, I'll
> modify this (and others, e.g. INPUT()) to handle it correctly. In
> other words, I think this can go in a separate patch.
>

Oh, nevermind, we actually do. I'll implement it in a follow up commit.

Thanks,

-- 
Davide

"There are no solved problems; there are only problems that are more
or less solved" -- Henri Poincare


More information about the llvm-commits mailing list