[PATCH] D13561: [ELF2] Make the system page size a target-dependent property

[Rui Ueyama via llvm-commits]

ruiu added inline comments.

================
Comment at: ELF/Target.cpp:367
@@ -360,2 +366,3 @@
   PltEntrySize = 8;
+  PageSize = 0x10000;
   VAStart = 0x400000;
----------------
Is 64KB page size standard on MIPS? (I'm not familiar with the platform.)

================
Comment at: ELF/Target.h:44
@@ -42,2 +43,3 @@
 protected:
+  unsigned PageSize;
   unsigned VAStart;
----------------
This is the same -- you want to set 0x1000 as default and assign only when a platform uses a different value. (I found I slightly prefer 4096 over 0x1000, but I can't explain why.)


http://reviews.llvm.org/D13561