[llvm] r249087 - AMDGPU: Move SIFixSGPRLiveRanges to be a regalloc pass

[Justin Bogner via llvm-commits]

Matt Arsenault <arsenm2 at gmail.com> writes:
>> On Oct 7, 2015, at 5:39 PM, Justin Bogner via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> 
>> So SIFixSGPRLiveRanges is causing machine verifier errors after this
>> commit, but we aren't seeing them because this also accidentally
>> disabled the running the verifier after the pass, because it turns out
>> `insertPass` doesn't schedule verification!
>
> This was intentional. For reasons I don’t fully understand/remember,
> everything in addOptimizedRegAlloc before RegisterCoalescer must
> disable the verifier. This is inserted between two other passes that
> also disable the verifier, so I think it’s supposed to be disabled.

I was under the impression that addPass calls that disable verification
are just bugs that we haven't had time to fix yet, no?