[PATCH] D13188: [MachO] Stop generating *coal* sections.

Akira Hatanaka via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 7 15:40:02 PDT 2015


ahatanak added a comment.

Perhaps I misunderstood the suggestion, but MachOUniquingMap will not have an entry that has key "__TEXT,__textcoal_n", is that right?

I think this change is fine for code-gen (if the code doesn't have any inline-asm), but would it also work when assembling a .s file or inline-asm statement? DarwinAsmParser calls MCContext::getMachOSection if it encounters section directive that switches to "__TEXT,__textcoal_n" in the .s file, but MCContext::getMachOSection wouldn't return section for "__TEXT,__text" if we didn't enter the entry for "__TEXT,__textcoal_n", would it?


http://reviews.llvm.org/D13188





More information about the llvm-commits mailing list