[PATCH] D13452: [asan] On OS X, log reports to syslog and os_trace (version 2)

[Alexander Potapenko via llvm-commits]

glider added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:378
@@ +377,3 @@
+
+void LogFullErrorReport(const char *error_message_buffer) {
+  // Log with os_trace. This will make it into the crash log.
----------------
There's a name clash between this parameter and the global variable.

================
Comment at: lib/sanitizer_common/sanitizer_mac.cc:399
@@ +398,3 @@
+  // Log to syslog.
+  // The logging on OS X may call pthread_create so we need the threading
+  // environment to be fully initialized. Also, this should never be called when
----------------
Any idea about the conditions under which the logging calls pthread_create?
Maybe we can warm up the logging subsystem when initializing ASan?
Will it help to create actual asl clients using asl_open()?


http://reviews.llvm.org/D13452