[PATCH] D13486: ELF2; Make singleton output sections globally accessible

[Rafael Ávila de Espíndola via llvm-commits]

rafael added a comment.

I like where this is going, but would you mind committing the changes moving stuff out of line first and rebase?

Thanks!


================
Comment at: ELF/InputSection.cpp:40
@@ -39,3 +37,2 @@
     uint32_t Type = RI.getType(IsMips64EL);
-    uintX_t GotVA = GotSec.getVA();
     uintX_t SymVA;
----------------
Why remove this?

================
Comment at: ELF/InputSection.h:78
@@ -77,3 +72,3 @@
 
-  OutputSection<ELFT> *Out = nullptr;
 
----------------
Independent change. Please commit the rename first.

================
Comment at: ELF/OutputSections.h:158
@@ -157,3 @@
-
-  void finalize() override {
-    this->Header.sh_size = getNumSymbols() * sizeof(Elf_Sym);
----------------
Moving it out of line is good, but please do it in a independent cleanup patch first.


http://reviews.llvm.org/D13486