[PATCH] D13468: [ELF2] -z now option implemented

[George Rimar via llvm-commits]

grimar added inline comments.

================
Comment at: ELF/Driver.cpp:139-143
@@ -138,1 +138,7 @@
 
+  for (auto *Arg : Args.filtered(OPT_z)) {
+    StringRef Opt = Arg->getValue();
+    if (Opt == "now")
+      Config->ZNow = true;
+  }
+
----------------
ruiu wrote:
> This can be
> 
>   for (auto *Arg : Args.filtered(OPT_z))
>     if (Arg->getValue() == "now")
>       Config->ZNow = true;
> 
Unfortunately no because getValue() returns char*. 

I'll rewrite to:
  if (Arg->getValue() == StringRef("now"))
    Config->ZNow = true;


http://reviews.llvm.org/D13468