[PATCH] D13358: InstCombine: Fold comparisons between unguessable allocas and other pointers

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 17:07:30 PDT 2015


majnemer accepted this revision.
majnemer added a comment.
This revision is now accepted and ready to land.

LGTM with nits addressed.


================
Comment at: lib/Transforms/InstCombine/InstCombineCompares.cpp:798
@@ +797,3 @@
+    for (Use &U : V->uses()) {
+      if (Worklist.size() == MaxIter)
+        return nullptr;
----------------
Can you make this `>=`, would make it a little easier to reason about.


http://reviews.llvm.org/D13358





More information about the llvm-commits mailing list