[PATCH] D13485: AMDGPU: Remove literal constants from VOP2b src0

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 15:51:54 PDT 2015


arsenm added inline comments.

================
Comment at: lib/Target/AMDGPU/SIInstrInfo.td:1190
@@ -1189,3 +1189,3 @@
 def VOP2b_I32_I1_I32_I32_I1 : VOPProfile<[i32, i32, i32, i1]> {
   let Src0RC32 = VCSrc_32;
   let Asm32 = "$dst, vcc, $src0, $src1, vcc";
----------------
tstellarAMD wrote:
> We already set Src0RC32 to the correct class here.
I didn't notice this. This seems to have been an accident before. I'll just add the comment to this


http://reviews.llvm.org/D13485





More information about the llvm-commits mailing list