[lld] r249368 - [elf2] Address style comments.
Michael Spencer via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 6 12:58:59 PDT 2015
On Tue, Oct 6, 2015 at 12:10 PM, Rafael EspĂndola
<rafael.espindola at gmail.com> wrote:
> Looks like we use upper case for lambdas, so AddStartEnd.
>
r249450
- Michael Spencer
> On 5 October 2015 at 22:13, Michael J. Spencer via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> Author: mspencer
>> Date: Mon Oct 5 21:13:54 2015
>> New Revision: 249368
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=249368&view=rev
>> Log:
>> [elf2] Address style comments.
>>
>> Modified:
>> lld/trunk/ELF/Writer.cpp
>>
>> Modified: lld/trunk/ELF/Writer.cpp
>> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Writer.cpp?rev=249368&r1=249367&r2=249368&view=diff
>> ==============================================================================
>> --- lld/trunk/ELF/Writer.cpp (original)
>> +++ lld/trunk/ELF/Writer.cpp Mon Oct 5 21:13:54 2015
>> @@ -329,15 +329,14 @@ template <class ELFT> void Writer<ELFT>:
>> DynamicSec.FiniArraySec =
>> Map.lookup({".fini_array", SHT_FINI_ARRAY, SHF_WRITE | SHF_ALLOC});
>>
>> - auto addStartEnd = [&Symtab](StringRef StartName, StringRef EndName,
>> - OutputSection<ELFT> *OS) {
>> + auto addStartEnd = [&Symtab](StringRef Start, StringRef End,
>> + OutputSection<ELFT> *OS) {
>> if (OS) {
>> - Symtab.addSyntheticSym<ELFT>(StartName, *OS, 0);
>> - Symtab.addSyntheticSym<ELFT>(EndName, *OS, OS->getSize());
>> - }
>> - else {
>> - Symtab.addIgnoredSym<ELFT>(StartName);
>> - Symtab.addIgnoredSym<ELFT>(EndName);
>> + Symtab.addSyntheticSym<ELFT>(Start, *OS, 0);
>> + Symtab.addSyntheticSym<ELFT>(End, *OS, OS->getSize());
>> + } else {
>> + Symtab.addIgnoredSym<ELFT>(Start);
>> + Symtab.addIgnoredSym<ELFT>(End);
>> }
>> };
>>
>>
>>
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
More information about the llvm-commits
mailing list