[PATCH] D13452: [asan] On OS X, log reports to syslog and os_trace (version 2)

[Evgeniy Stepanov via llvm-commits]

eugenis added inline comments.

================
Comment at: lib/sanitizer_common/sanitizer_common.cc:322
@@ +321,3 @@
+    if (s != z) {
+      *z = *s;
+      z++;
----------------
a shorter way to do the same:
  if (s ! = z) *z = *s;
  z++;
  s++;
}

================
Comment at: lib/sanitizer_common/sanitizer_common.h:659
@@ +658,3 @@
+  SANITIZER_TYPE_UNKNOWN
+};
+
----------------
We already have knowledge of the current sanitizer: SanitizerToolName. Could you either dispatch on that, or use it directly?

================
Comment at: lib/sanitizer_common/tests/sanitizer_common_test.cc:221
@@ +220,3 @@
+    "123[653456789012",                       "123[653456789012",
+    "Normal \033[5mBlink \033[25mNormal",     "Normal Blink Normal",
+    "",                                       "",
----------------
Please test 2 ansi sequencies  with nothing in between.

================
Comment at: test/asan/lit.cfg:39
@@ -37,2 +38,3 @@
   default_asan_opts = 'abort_on_error=0'
+  default_asan_opts += ':log_to_syslog=0'
 if default_asan_opts:
----------------
This way log_to_syslog is completely untested. How bad is it? Is there a way to tune this down, but still exercise the logging code?



http://reviews.llvm.org/D13452