[PATCH] D13360: [llvm-objdump] Teach -d about AArch64 mapping symbols

Rafael Ávila de Espíndola via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 12:08:03 PDT 2015


rafael added a comment.

Much better, but I think it can still be improved.

  auto DAI =
            std::lower_bound(Symbols.begin(), Symbols.end(), Index, SymCmp);

Index is >= Start, so you don't need to search past Symbols[si], no?

In fact, why do you need to search at all? When you are about to print a symbol from Start to End, you can check if the range for that symbol is data or not and you can do that by just maintaining a single "InCode" variable that is updated every time you pass a $x or $d.


http://reviews.llvm.org/D13360





More information about the llvm-commits mailing list