[PATCH] D13466: [AArch64] Implement vector splitting on UADDV.

[Jun Bum Lim via llvm-commits]

junbuml added a comment.

Thanks Charlie for this patch.


================
Comment at: lib/Target/AArch64/AArch64ISelLowering.cpp:9614
@@ +9613,3 @@
+  uint64_t IdxVal = cast<ConstantSDNode>(Idx)->getZExtValue();
+  Hi = DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, HiVT, N->getOperand(0),
+                   DAG.getConstant(IdxVal + LoVT.getVectorNumElements(), dl,
----------------
Do we need to split into Lo and Hi again here. 
Is  "std::tie(Lo, Hi) = DAG.SplitVectorOperand(N, 0);" not enough? 


http://reviews.llvm.org/D13466