[PATCH] D13348: [InstCombine] SSE4A constant folding and conversion to shuffles.

[Andrea Di Biagio via llvm-commits]

andreadb added a comment.

Hi Simon,

Overall, the patch seems reasonable.
However, I think it would be better if you send the fix for the wrong merging of pairs of insertqi calls as a separate patch.

I also noticed that your code converts an extrq/insertq with constant width and length into an extrqi/insertqi.
Have you considered the possibility of moving the logic that folds extrqi/insertqi into separate functions?
If you do that, then you could simplify 'extrq'/'insertq' in one step rather than going through the preliminar extra step of converting extrq/insertq to insertqi/extrqi. Basically what I am suggesting (if possible) is to change the code so that we simplify extrq/insertq in one step rather than in two steps.

-Andrea


Repository:
  rL LLVM

http://reviews.llvm.org/D13348