[PATCH] D13443: Rework the LTO Pipeline, aligning closer to the O2/O3 pipeline.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 6 07:09:18 PDT 2015


tejohnson added inline comments.

================
Comment at: include/llvm/Transforms/IPO/PassManagerBuilder.h:149
@@ -147,3 +148,3 @@
   void addInitialAliasAnalysisPasses(legacy::PassManagerBase &PM) const;
   void addLTOOptimizationPasses(legacy::PassManagerBase &PM);
   void addLateLTOOptimizationPasses(legacy::PassManagerBase &PM);
----------------
Can this be removed? I think it is dead code now.

================
Comment at: lib/Transforms/IPO/PassManagerBuilder.cpp:582
@@ -564,3 +581,3 @@
   // Drop bodies of available externally objects to improve GlobalDCE.
   PM.add(createEliminateAvailableExternallyPass());
 
----------------
This can be removed - it only needs to be called once and now the LTO pipeline calls it via addLTOOptimizationPasses.


http://reviews.llvm.org/D13443





More information about the llvm-commits mailing list