[PATCH] D13432: cmake: Avoid leading space in LLVM_DEFINITIONS.
Johannes S. Mueller-Roemer via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 6 04:31:43 PDT 2015
jsroemer added a comment.
In http://reviews.llvm.org/D13432#260574, @chfast wrote:
> I agree target_compile_definitions and others are super nice. But that transition would probably take some time and might break many things. I'm also not sure that information will be preserved by exported targets. However I can start working on that as a separated change after broader acceptance.
>
> This change is a quick fix. Not very beautiful but helps in my case.
Does turning it back into a list break anything? If not the "quick fix" might be as easy as removing the quotes from the set line.
http://reviews.llvm.org/D13432
More information about the llvm-commits
mailing list